Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDK values for node and unity-web #797

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Add SDK values for node and unity-web #797

merged 3 commits into from
Sep 3, 2024

Conversation

bcherry
Copy link
Contributor

@bcherry bcherry commented Aug 29, 2024

We'd like to be able to distinguish these SDKs from their underlying implementations (Rust and JS).

I'm not sure if there is more I'm supposed to do for testing when submitting a protocol PR so lmk.

Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: d8590bc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@lukasIO
Copy link
Contributor

lukasIO commented Sep 3, 2024

@bcherry I'll merge this and cut a new release so we can start implementing this.

@lukasIO lukasIO merged commit 9dbb7b5 into main Sep 3, 2024
3 checks passed
@lukasIO lukasIO deleted the bcherry/sdk_values branch September 3, 2024 07:36
@github-actions github-actions bot mentioned this pull request Sep 3, 2024
@bcherry
Copy link
Contributor Author

bcherry commented Sep 3, 2024

@lukasIO thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants