-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for key/value attributes on Participant #733
Merged
Merged
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0996b5e
Support for key/value attributes on Participant
davidzhao 8a15772
generated protobuf
github-actions[bot] 2edb413
Attribute support for SIP.
dennwc e8448b7
generated protobuf
github-actions[bot] 008e03f
Merge branch 'main' into attributes
davidzhao 5b8d658
generated protobuf
github-actions[bot] c03793c
allow specifying attributes during token generation
davidzhao 34ad2db
Remove sip prefix and rename phone number attrs.
dennwc bf6d9b4
Merge remote-tracking branch 'refs/remotes/origin/main' into attributes
dennwc 7046bee
regenerate protos
dennwc 05359df
update tests
dennwc 031b1e9
add kv attrs to sip token
dennwc 7213b9a
add attribute test
davidzhao a4d0f89
changeset
davidzhao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package livekit | ||
|
|
||
| // Names of participant attributes for SIP. | ||
| const ( | ||
| // AttrSIPPrefix is shared for all SIP attributes. | ||
| AttrSIPPrefix = "lk.sip." | ||
| // AttrSIPCallID attribute contains LiveKit SIP call ID. | ||
| AttrSIPCallID = AttrSIPPrefix + "callID" | ||
| // AttrSIPTrunkID attribute contains LiveKit SIP Trunk ID used for the call. | ||
| AttrSIPTrunkID = AttrSIPPrefix + "trunkID" | ||
| // AttrSIPDispatchRuleID attribute contains LiveKit SIP DispatchRule ID used for the inbound call. | ||
| AttrSIPDispatchRuleID = AttrSIPPrefix + "ruleID" | ||
| // AttrSIPFromNumber attribute contains number from which the call was made. | ||
| // This attribute will be omitted if HidePhoneNumber is set. | ||
| AttrSIPFromNumber = AttrSIPPrefix + "fromNumber" | ||
davidzhao marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // AttrSIPToNumber attribute contains number to which the call was made. | ||
| // This attribute will be omitted if HidePhoneNumber is set. | ||
| AttrSIPToNumber = AttrSIPPrefix + "toNumber" | ||
| ) | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think the
lk.namespace adds value here? IMO since we don't have any reserved namespace, it could just be tagged SIP?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for us not wanting a reserved namespace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the mechanism for us to set these attributes is via token grants, we do not have a way to enforce that a particular component is SIP vs something else. Since the developer is responsible for issuing tokens, they should be "trusting" information that they are providing.