Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional SIP transports #719

Merged
merged 1 commit into from
May 23, 2024
Merged

Add support for additional SIP transports #719

merged 1 commit into from
May 23, 2024

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented May 21, 2024

Add support for additional SIP transports:

  • TCP (in progress)
  • TLS (for the future)

@dennwc dennwc self-assigned this May 21, 2024
Copy link

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: 658797d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@dennwc dennwc force-pushed the sip-transport branch 2 times, most recently from 107bc1f to 67ba0a5 Compare May 21, 2024 14:05
@dennwc dennwc requested a review from davidzhao May 22, 2024 10:11
@dennwc
Copy link
Contributor Author

dennwc commented May 23, 2024

@biglittlebigben Done! Decided to keep a single transport on the Trunk level and added a helper for internal RPC (will be shared by OSS and Cloud).

@dennwc dennwc requested a review from biglittlebigben May 23, 2024 16:09
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

@dennwc dennwc merged commit 90dfd66 into main May 23, 2024
3 checks passed
@dennwc dennwc deleted the sip-transport branch May 23, 2024 17:14
This was referenced May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants