Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICERestartWHIPResource to RPC #716

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

Sean-Der
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: c991b6d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@Sean-Der Sean-Der marked this pull request as draft May 13, 2024 20:37
@Sean-Der
Copy link
Contributor Author

Marking as draft. Should be tested against a client before worth reviewing

@Sean-Der Sean-Der marked this pull request as ready for review May 14, 2024 03:11
@Sean-Der
Copy link
Contributor Author

@biglittlebigben I think this one is ok to review/merge. If you are happy with the structure of the other PR I don't see why this would change.

Copy link
Contributor

@biglittlebigben biglittlebigben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@davidzhao davidzhao merged commit 5aa3d97 into livekit:main May 14, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request May 13, 2024
@Sean-Der Sean-Der deleted the ice-restart branch May 14, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants