Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Twirp interceptor that prints curl commands #702

Merged
merged 2 commits into from
May 1, 2024
Merged

Add Twirp interceptor that prints curl commands #702

merged 2 commits into from
May 1, 2024

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented Apr 30, 2024

Add Twirp interceptor that prints curl commands for each request made. It will be then used in our CLI.

@dennwc dennwc self-assigned this Apr 30, 2024
Copy link

changeset-bot bot commented Apr 30, 2024

⚠️ No Changeset found

Latest commit: dcd288e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! do you see other things using it too? or is it a cli-specific interceptor?

@dennwc
Copy link
Contributor Author

dennwc commented May 1, 2024

@davidzhao I was thinking about this too. Maybe it would be useful for lkctl, but apart from that ti could be moved to livekit-cli instead of the protocol. The only reason I put it here is because it does depend on the protocol used (Twirp).

@dennwc dennwc merged commit e0c63d7 into main May 1, 2024
2 checks passed
@dennwc dennwc deleted the proto-curl branch May 1, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants