Separate protobufs and set up changesets publishing workflow #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocol into lukas/changesets-publishing
lukasIO
changed the title
paulwe
approved these changes
Mar 6, 2024
dennwc
approved these changes
Mar 6, 2024
| { | ||
| "name": "github.com/livekit/protocol", | ||
| "private": true, | ||
| "version": "1.10.1", |
There was a problem hiding this comment.
Would we need to update the version here when tagging a new release?
Same question for packages/javascript/package.json.
What's the difference between the two, btw? It's for compatibility, I assume?
There was a problem hiding this comment.
No, this will automatically be done by the changesets PR.
Here's an example of what that looks like on the client-sdk-js.
Once merged, the release action will create the git tag.
One (the one in the javascript folder) is for tracking the changes of the JS package, the other one (in root) will track the golang module.
|
hm, not sure why the test action started to fail with 323b7c6. Failures look unrelated |
|
re-run of the tests was successful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up changesets to track both the go module and the javascript package.
I declared them as
fixedin the changesets config so that if either one gets version bumped, the other will as well.Moved all .proto files into
./protobufs.The release action will automatically publish the javascript package to npm and generate a git tag (which is practically also a release of the go module) whenever the
Version PackagesPR gets merged into main.This PR will automatically be created when the release action detects a new changeset in the repo.
For changes that should cause a version bump, either
pnpm changesetlocally within the repo and commit the changeset or