Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ConnectionQuality DISCONNECTED -> LOST #531

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Rename ConnectionQuality DISCONNECTED -> LOST #531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4307bf
Rename ConnectionQuality DISCONECTED -> LOST
boks1971 Nov 29, 2023
0400f00
generated protobuf
github-actions[bot] Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 46 additions & 47 deletions livekit/livekit_models.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion livekit_models.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ enum ConnectionQuality {
POOR = 0;
GOOD = 1;
EXCELLENT = 2;
DISCONNECTED = 3;
LOST = 3;
}

message ParticipantTracks {
Expand Down
4 changes: 2 additions & 2 deletions utils/connectionquality.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ import (
)

func IsConnectionQualityLower(prev livekit.ConnectionQuality, curr livekit.ConnectionQuality) bool {
if prev != livekit.ConnectionQuality_DISCONNECTED && curr == livekit.ConnectionQuality_DISCONNECTED {
if prev != livekit.ConnectionQuality_LOST && curr == livekit.ConnectionQuality_LOST {
return true
}

if prev == livekit.ConnectionQuality_DISCONNECTED && curr != livekit.ConnectionQuality_DISCONNECTED {
if prev == livekit.ConnectionQuality_LOST && curr != livekit.ConnectionQuality_LOST {
return false
}

Expand Down
Loading