Add SIP RPC #514
Merged
Add SIP RPC #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sean-Der
force-pushed
the
sip
branch
11 times, most recently
from
bde1802 to
3286488
Compare
dennwc
reviewed
Nov 13, 2023
| // Username and password used to authenticate inbound and outbound SIP invites | ||
| // May be empty to have no Authentication | ||
| string username = 5; | ||
| string password = 6; |
There was a problem hiding this comment.
Not exactly a protocol issue, but are there requirements about encrypting user credentials we need to store?
davidzhao
approved these changes
Nov 13, 2023
| // Username and password used to authenticate inbound and outbound SIP invites | ||
| // May be empty to have no Authentication | ||
| string username = 6; | ||
| string password = 7; |
There was a problem hiding this comment.
we should mask or return blank username/password when listing/getting trunks.
| import "options.proto"; | ||
|
|
||
| service SIPInternal { | ||
| rpc UpdateSIPParticipant(InternalUpdateSIPParticipantRequest) returns (InternalUpdateSIPParticipantResponse) { |
There was a problem hiding this comment.
looks like this is just a placeholder? I think we'll want topic based routing to the node hosting the participant instead of affinity based selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.