Add playoutdelay to CreateRoomRequest (#439)

* Add playoutdelay to CreateRoomRequest * generated protobuf * Remove max from PlayoutDelay * generated protobuf --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
livekit · Aug 3, 2023 · d791f31 · d791f31
1 parent caf65eb
commit d791f31
Show file tree

Hide file tree

Showing 6 changed files with 622 additions and 617 deletions.
diff --git a/livekit/livekit_models.pb.go b/livekit/livekit_models.pb.go
diff --git a/livekit/livekit_room.pb.go b/livekit/livekit_room.pb.go
diff --git a/livekit/livekit_room.twirp.go b/livekit/livekit_room.twirp.go
diff --git a/livekit_models.proto b/livekit_models.proto
@@ -60,7 +60,6 @@ enum VideoCodec {
 message PlayoutDelay {
   bool enabled = 1;
   uint32 min = 2;
-  uint32 max = 3;
 }
 
 message ParticipantPermission {

diff --git a/livekit_room.proto b/livekit_room.proto
@@ -74,6 +74,8 @@ message CreateRoomRequest {
   string metadata = 5;
   // egress
   RoomEgress egress = 6;
+  // minimum playout delay of subscriber
+  uint32 min_playout_delay = 7;
 }
 
 message RoomEgress {

diff --git a/sdp/sdp.go b/sdp/sdp.go
@@ -136,7 +136,6 @@ func ExtractICECredential(desc *sdp.SessionDescription) (string, string, error)
 }
 
 func ExtractStreamID(media *sdp.MediaDescription) (string, bool) {
-	// last video is pending for publish, set codec preference
 	var streamID string
 	msid, ok := media.Attribute(sdp.AttrKeyMsid)
 	if !ok {