Skip to content

Commit

Permalink
Use dialtone instead of ringtone
Browse files Browse the repository at this point in the history
  • Loading branch information
biglittlebigben committed Oct 21, 2024
1 parent 24407c1 commit 83ec971
Show file tree
Hide file tree
Showing 6 changed files with 400 additions and 384 deletions.
362 changes: 188 additions & 174 deletions livekit/livekit_sip.pb.go

Large diffs are not rendered by default.

279 changes: 140 additions & 139 deletions livekit/livekit_sip.twirp.go

Large diffs are not rendered by default.

11 changes: 6 additions & 5 deletions protobufs/livekit_sip.proto
Original file line number Diff line number Diff line change
Expand Up @@ -401,8 +401,9 @@ message CreateSIPParticipantRequest {
// Character 'w' can be used to add a 0.5 sec delay.
string dtmf = 5;

// Optionally play ringtone in the room as an audible indicator for existing participants
bool play_ringtone = 6;
// Optionally play dialtone in the room as an audible indicator for existing participants. The `play_ringtone` option is deprectated but has the same effect.
bool play_ringtone = 6 [deprecated = true];
bool play_dialtone = 13;

// By default the From value (Phone number) is used for participant name/identity (if not set) and added to attributes.
// If true, a random value for identity will be used and numbers will be omitted from attributes.
Expand All @@ -413,7 +414,7 @@ message CreateSIPParticipantRequest {
// Max call duration.
google.protobuf.Duration max_call_duration = 12;

// NEXT ID: 13
// NEXT ID: 14
}

message SIPParticipantInfo {
Expand All @@ -428,8 +429,8 @@ message TransferSIPParticipantRequest {
string room_name = 2;
string transfer_to = 3;

// Optionally play ringtone to the SIP participant as an audible indicator of being transferred
bool play_ringtone = 4;
// Optionally play dialtone to the SIP participant as an audible indicator of being transferred
bool play_dialtone = 4;
}

message SIPCallInfo {
Expand Down
8 changes: 4 additions & 4 deletions protobufs/rpc/sip.proto
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ message InternalCreateSIPParticipantRequest {
// Character 'w' can be used to add a 0.5 sec delay.
string dtmf = 11;

// Optionally play ringtone in the room as an audible indicator for existing participants
bool play_ringtone = 12;
// Optionally play dialtone in the room as an audible indicator for existing participants
bool play_dialtone = 12;

map<string, string> headers = 21;
map<string, string> headers_to_attributes = 22;
Expand All @@ -100,6 +100,6 @@ message InternalTransferSIPParticipantRequest {
string sip_call_id = 1;
string transfer_to = 2;

// Optionally play ringtone to the SIP participant as an audible indicator of being transferred
bool play_ringtone = 3;
// Optionally play dialtone to the SIP participant as an audible indicator of being transferred
bool play_dialtone = 3;
}
24 changes: 12 additions & 12 deletions rpc/sip.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

100 changes: 50 additions & 50 deletions rpc/sip.psrpc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 83ec971

Please sign in to comment.