add IsEmpty

livekit · Nov 24, 2024 · 28e4467 · 28e4467
1 parent 0d5ca88
commit 28e4467
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/utils/metrics_batch_builder.go b/utils/metrics_batch_builder.go
@@ -274,6 +274,10 @@ func (m *MetricsBatchBuilder) Merge(other *livekit.MetricsBatch) {
 	}
 }
 
+func (m *MetricsBatchBuilder) IsEmpty() bool {
+	return len(m.MetricsBatch.TimeSeries) == 0 && len(m.MetricsBatch.Events) == 0
+}
+
 func (m *MetricsBatchBuilder) isLabelFiltered(label livekit.MetricLabel, participantIdentity livekit.ParticipantIdentity) bool {
 	if participantIdentity == m.restrictedLabels.ParticipantIdentity {
 		// all labels allowed for restricted participant

diff --git a/utils/metrics_batch_builder_test.go b/utils/metrics_batch_builder_test.go
@@ -36,6 +36,7 @@ func TestMetricsBatchBuilder(t *testing.T) {
 		}
 
 		mbb := NewMetricsBatchBuilder()
+		require.True(t, mbb.IsEmpty())
 		mbb.SetTime(
 			time.Unix(0, expected.TimestampMs*int64(time.Millisecond)),
 			expected.NormalizedTimestamp.AsTime(),
@@ -165,6 +166,7 @@ func TestMetricsBatchBuilder(t *testing.T) {
 			Rid: "f",
 		})
 		require.NoError(t, err)
+		require.False(t, mbb.IsEmpty())
 
 		// should not be able to add sample to invalid index
 		err = mbb.AddMetricSamplesToTimeSeriesMetric(-1, nil)