Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lk): use tmp directory while preparing files #441

Conversation

rektdeckard
Copy link
Contributor

@rektdeckard rektdeckard commented Oct 9, 2024

https://linear.app/livekit/issue/DEX-820/use-tmp-for-working-files-in-indeterminate-state

  • Use os.TempDir() while files are in an indeterminate state (E.G. while bootstrapping a template repository), relocating them after to the desired path
  • Better logging of unexpected errors during bootstrap

@rektdeckard rektdeckard requested a review from davidzhao October 9, 2024 23:00
@rektdeckard rektdeckard force-pushed the tobias/dex-820-use-tmp-for-working-files-in-indeterminate-state branch from 03729d5 to 06923f7 Compare October 9, 2024 23:00
@rektdeckard rektdeckard requested a review from dennwc October 17, 2024 04:41
cmd/lk/utils.go Outdated Show resolved Hide resolved
cmd/lk/utils.go Outdated Show resolved Hide resolved
cmd/lk/utils.go Outdated Show resolved Hide resolved
cmd/lk/app.go Outdated Show resolved Hide resolved
@rektdeckard rektdeckard merged commit 4f69117 into main Oct 17, 2024
3 checks passed
@rektdeckard rektdeckard deleted the tobias/dex-820-use-tmp-for-working-files-in-indeterminate-state branch October 17, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants