Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize safe names on project auth #437

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

davidzhao
Copy link
Member

the rest of tooling is set to use the standard name. doing it on the reader path tend to create inconsistencies in behavior (for example set-default did not work for me)

the rest of tooling is set to use the standard name. doing it on the reader
path tend to create inconsistencies in behavior (for example set-default did not work for me)
@davidzhao davidzhao requested a review from rektdeckard October 4, 2024 00:18
Copy link
Contributor

@rektdeckard rektdeckard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd, set-default works for me, tested using both canonical name and url-safe names. But I suppose ultimately it is simpler to just use only url-safe names for everything

@davidzhao
Copy link
Member Author

I'm traced it to a reason earlier.. and I think it had to do with how the projects were set up. There were other issues with it

  • adding the same project again, didn't fail, because I had an existing project where name was equal to the new would be url-safe name.
  • I had a few projects that had the similar domain prefixes (not cloud), but different names. when List was using url-safe names, they were not possible to distinguish from each other.

@davidzhao davidzhao merged commit f81acb5 into main Oct 4, 2024
3 checks passed
@davidzhao davidzhao deleted the dz/consistent-name branch October 4, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants