Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): allow opening browser to fail silently during auth #435

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix(auth): allow opening browser to fail silently during auth #435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions cmd/lk/cloud.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,9 +294,7 @@ func tryAuthIfNeeded(ctx context.Context, cmd *cli.Command) error {

// poll for keys
fmt.Printf("Please confirm access by visiting:\n\n %s\n\n", authURL.String())
if err := browser.OpenURL(authURL.String()); err != nil {
return err
}
browser.OpenURL(authURL.String()) // discard result; this will fail in headless environments

var ak *ClaimAccessKeyResponse
var pollErr error
Expand Down
Loading