Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(deps): update module github.com/livekit/protocol to v1.23.0" #429

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Revert "fix(deps): update module github.com/livekit/protocol to v1.23.0" #429

merged 1 commit into from
Sep 24, 2024

Conversation

rektdeckard
Copy link
Contributor

Reverts #427

davidzhao
davidzhao approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, is it a breaking change?

@rektdeckard
Copy link
Contributor Author

rektdeckard commented Sep 24, 2024 •
edited
Loading

Yup, something broke here, needs to be looked at a little closer and right this second not the time

tobiasfried@slate /tmp % lk --help
zsh: killed     lk --help

@rektdeckard rektdeckard merged commit acedde0 into main Sep 24, 2024
3 checks passed
@rektdeckard rektdeckard deleted the revert-427-renovate/github.com-livekit-protocol-1.x branch September 24, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rektdeckard @davidzhao