Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): use written install instructions instead of automatic #418

Merged

Conversation

rektdeckard
Copy link
Contributor

@rektdeckard rektdeckard commented Sep 17, 2024

Instead of taking the place of tools devs are already familiar with, just print out the steps for devs to run themselves.

tobiasfried@slate /tmp % lk app sandbox --id 5lfwjtkd6cy
Using default project [Atrium]
Cloning template...
Instantiating environment...
Running task post_create_sandbox...
To setup and run the agent:

    cd /tmp/optimized-instance/agent
    python3 -m venv venv
    source venv/bin/activate
    python3 -m pip install -r requirements.txt
    python3 agent.py start

tobiasfried@slate /tmp %

@rektdeckard rektdeckard force-pushed the tobias/dex-733-cli-should-not-automate-common-dev-tasks branch from ec7e41c to 2863f2c Compare September 17, 2024 20:18
@rektdeckard rektdeckard force-pushed the tobias/dex-733-cli-should-not-automate-common-dev-tasks branch from 2863f2c to 0cb1f15 Compare September 17, 2024 20:58
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome. this looks good.

do we also allow custom text to be included with each example app?

@rektdeckard
Copy link
Contributor Author

@davidzhao yep, every app customizes the (optional) text that appears on initializing a sandbox, and another on bootstrap.

@rektdeckard rektdeckard merged commit aaf8002 into main Sep 18, 2024
3 checks passed
@rektdeckard rektdeckard deleted the tobias/dex-733-cli-should-not-automate-common-dev-tasks branch September 18, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants