Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cmd): cleanup for sbx internal alpha #410

Merged
merged 8 commits into from
Sep 13, 2024
Merged

chore(cmd): cleanup for sbx internal alpha #410

merged 8 commits into from
Sep 13, 2024

Conversation

rektdeckard
Copy link
Contributor

@rektdeckard rektdeckard commented Sep 12, 2024 •
edited
Loading

  • Minor cleanup around sandbox/bootstrap commands
  • Bump version to 2.1.1. Though you could consider this a 2.2.0-alpha.1, it's easier to release this way for homebrew and winget.

davidzhao
davidzhao reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of nits

cmd/lk/app.go Outdated Show resolved Hide resolved
@rektdeckard rektdeckard merged commit fd57e9c into main Sep 13, 2024
3 checks passed
@rektdeckard rektdeckard deleted the tf/sbx-env branch September 13, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

@dennwc dennwc Awaiting requested review from dennwc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rektdeckard @davidzhao