Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send and receive DTMF in join command. #393

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Send and receive DTMF in join command. #393

merged 1 commit into from
Aug 22, 2024

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented Aug 20, 2024

Switch to the new OnDataPacket callback instead of the legacy OnDataReceived. Add flags for publishing DTMF and user data to lk room join. Legacy lk join-room still uses old callback and doesn't support new flags.

@dennwc dennwc requested a review from rektdeckard August 20, 2024 11:33
@dennwc dennwc self-assigned this Aug 20, 2024
Copy link
Contributor

@rektdeckard rektdeckard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

cmd/lk/room.go Show resolved Hide resolved
@dennwc dennwc merged commit d687a53 into main Aug 22, 2024
3 checks passed
@dennwc dennwc deleted the dtmf branch August 22, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants