Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for agent dispatch management #383

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

biglittlebigben
Copy link
Contributor

This PR adds support for agent dispatch management through integration with the agent dispatch service.

@biglittlebigben biglittlebigben requested a review from paulwe August 8, 2024 18:30
var (
AgentDispatchCommands = []*cli.Command{
{
Name: "agentdispatch",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably discuss the proper name/command hierarchy here, since agentdispatch may not be clear

Copy link
Contributor

@rektdeckard rektdeckard Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see nothing wrong with making dispatch a subcommand of agent command:

lk agent dispatch create --room my_room --agent-name bot

Commands: []*cli.Command{
{
Name: "create",
Usage: "Create an agent dispatches",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Usage: "Create an agent dispatches",
Usage: "Create an agent dispatch",

Comment on lines 41 to 57
Flags: []cli.Flag{
&cli.StringFlag{
Name: "room",
Usage: "`Name` of the room to create the dispatch in",
Required: true,
},
&cli.StringFlag{
Name: "agent-name",
Usage: "`Agent Name` to dispatch the job to",
Required: false,
},
&cli.StringFlag{
Name: "metadata",
Usage: "`Metadata` to pass to the agent workers",
Required: false,
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: SHOUTING_CASE for arg names

var (
AgentDispatchCommands = []*cli.Command{
{
Name: "agentdispatch",
Copy link
Contributor

@rektdeckard rektdeckard Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see nothing wrong with making dispatch a subcommand of agent command:

lk agent dispatch create --room my_room --agent-name bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants