Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject ingress if Enabled flag is false #319

Merged

Conversation

Rajiv91
Copy link
Contributor

@Rajiv91 Rajiv91 commented Dec 31, 2024

Do not merge until merge protocol pr!!:
livekit/protocol#935
And livekit pr:
livekit/livekit#3293

@Rajiv91 Rajiv91 requested a review from a team as a code owner December 31, 2024 01:00
@CLAassistant
Copy link

CLAassistant commented Dec 31, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@biglittlebigben biglittlebigben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will approve once dependencies are merged and updated.

@Rajiv91 Rajiv91 changed the title reject ingress if sessionEnabled flag is false reject ingress if Enabled flag is false Jan 7, 2025
@Rajiv91 Rajiv91 changed the title reject ingress if Enabled flag is false Reject ingress if Enabled flag is false Jan 7, 2025
@biglittlebigben biglittlebigben merged commit 5315215 into livekit:main Jan 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants