playlist upload backoff #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biglittlebigben
approved these changes
Sep 19, 2024
pkg/pipeline/sink/segments.go
Outdated
| func (s *SegmentSink) shouldUploadPlaylist() bool { | ||
| // with the default of 6s segments, this will upload every update for the first hour, then every | ||
| // other update for the second, every third update for the third, etc. | ||
| return s.segmentCount < 600 || s.segmentCount%(s.segmentCount/600) == 0 |
There was a problem hiding this comment.
Should we cap the interval between uploads? Uploading every 30 segments for broadcasts > 30h means you can miss up to 3min of broadcast if the pod crashes. Maybe upload at least once every 10 segments?
There was a problem hiding this comment.
forgot to push that change, I'll update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploads once every N updates where N is the number of hours (when using the default duration) that have passed