Eos timer #541
Merged
Eos timer #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidzhao
reviewed
Nov 18, 2023
pkg/pipeline/watch.go
Outdated
| @@ -121,6 +121,7 @@ func (c *Controller) messageWatch(msg *gst.Message) bool { | |||
| switch msg.Type() { | |||
| case gst.MessageEOS: | |||
| logger.Infow("EOS received") | |||
| c.eosTimer.Stop() | |||
There was a problem hiding this comment.
nil check? possible EOS is sent by something else?
There was a problem hiding this comment.
shouldn't be possible but might as well add it
| c.eosTimer = time.AfterFunc(time.Second*30, func() { | ||
| c.OnError(errors.ErrPipelineFrozen) | ||
| }) | ||
| c.p.SendEOS() |
There was a problem hiding this comment.
Will this be confusing if we mark the session as failed, but the media is still available in the end?
There was a problem hiding this comment.
the media won't be available if the eos is never received
There was a problem hiding this comment.
(unless it's HLS, in which case the playlist will not be closed)
There was a problem hiding this comment.
My question is about calling c.OnError(errors.ErrPipelineFrozen) after 30s.
davidzhao
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.