Add more options to the S3 section of config.yaml for egress #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dandoug
force-pushed
the
add-s3-proxy-config
branch
from
cd51bf7 to
2fe010a
Compare
- HTTP proxy - max retries - max/min retry delay - AWS logging option
dandoug
force-pushed
the
add-s3-proxy-config
branch
from
2fe010a to
93ebc2d
Compare
|
sorry for the force pushes... I tried to move this to be based on 1.8.0, but that requires a version of livekit-server not yet available so I moved back to be based on 1.7.12 |
|
btw... I reviewed the CLA with the eBay Open Source counsel this morning and he confirmed that we had no issues with it as long as the PR did not contain eBay propriety information or patentable IP. I assured him that it did not. |
|
Closing in favor of #529. We're releasing livekit server v1.5.1 today so you should be able to move to 1.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional S3 configuration to the
config.yamlfor egress to allow specification ofThe change does not alter the
livekit.S3Uploadstruct which is shared across components. It extends it within the egress component to add the additional information. The intended usage is in an environment where egress files on requests would NOT specify the S3 file information.... but if such info was specified, the information in the extended part of the s3config.yamlwould be added (uploads.go lines 48-56).