Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix start after stopping #511

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Fix start after stopping #511

merged 1 commit into from
Oct 18, 2023

Conversation

nkonev
Copy link
Contributor

@nkonev nkonev commented Oct 16, 2023

Hi!
I noticed that start-after-stopping isn't working in the latest version v1.7.12. It seems it caused by 331c179.

PTAL @frostbyte73

Reproduction is the same as in my previous PR #132
start the container
stop
start again and see pulseaudio's error in the log

Also it probably can address #501 - very similar symptoms

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2023

CLA assistant check
All committers have signed the CLA.

@nkonev nkonev marked this pull request as draft October 17, 2023 11:21
@nkonev nkonev marked this pull request as ready for review October 17, 2023 11:28
@nkonev
Copy link
Contributor Author

nkonev commented Oct 17, 2023

The test failure looks unrelated, if I understood correctly, Github does not pass EGRESS_CONFIG_STRING="$(echo ${{ secrets.EGRESS_CONFIG_STRING }} | base64 -d)" for builds, triggered by me

cc @biglittlebigben @frostbyte73

@frostbyte73 frostbyte73 merged commit 83d2332 into livekit:main Oct 18, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants