Support for Image output in egress #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amin/image_output
frostbyte73
reviewed
Oct 2, 2023
frostbyte73
reviewed
Oct 2, 2023
| @@ -33,5 +34,9 @@ func BuildWebsocketBin(pipeline *gstreamer.Pipeline, appSinkCallbacks *app.SinkC | |||
| return nil, err | |||
| } | |||
|
|
|||
| b.SetGetSrcPad(func(name string) *gst.Pad { | |||
There was a problem hiding this comment.
this probably isn't needed since the sink will only have one template
frostbyte73
reviewed
Oct 2, 2023
| } | ||
|
|
||
| var w, h uint32 | ||
| for _, t := range rp.Tracks() { |
There was a problem hiding this comment.
what happens if the participant publishes video late?
There was a problem hiding this comment.
Currently, it will default to the video encoding settings (which themselves default to 1080p). I just added a small fix to make sure this is true.
Changing the behavior to start the image output only when a video track joins would be better, but I do not have any way to add the image output on the running pipeline yet. This will come when I implement "UpdateOutputs".
frostbyte73
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds preliminary support for generating images at regular interval for a session in egress. This is still mostly untested with only basic integration test support.