sync set pipeline null (#490)

livekit · Sep 14, 2023 · ee559a4 · ee559a4
1 parent b1dee22
commit ee559a4
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/pkg/gstreamer/pipeline.go b/pkg/gstreamer/pipeline.go
@@ -157,18 +157,18 @@ func (p *Pipeline) Stop() {
 	}
 
 	if err := p.OnStop(); err != nil {
-		logger.Errorw("onStop failure", err)
 		p.OnError(err)
 	}
 
 	if old >= StateRunning {
 		p.loop.Quit()
 	}
 
+	if err := p.SetState(gst.StateNull); err != nil {
+		logger.Errorw("failed to set pipeline to null", err)
+	}
+
 	p.UpgradeState(StateFinished)
-	go func() {
-		_ = p.pipeline.SetState(gst.StateNull)
-	}()
 }
 
 func (p *Pipeline) DebugBinToDotData(details gst.DebugGraphDetails) string {