Skip to content

Commit

Permalink
remove noisy logs (#557)
Browse files Browse the repository at this point in the history
  • Loading branch information
frostbyte73 authored Dec 8, 2023
1 parent 3cd6379 commit c23c430
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
2 changes: 0 additions & 2 deletions pkg/pipeline/sink/uploader/uploader.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import (
"github.com/livekit/egress/pkg/stats"
"github.com/livekit/egress/pkg/types"
"github.com/livekit/protocol/livekit"
"github.com/livekit/protocol/logger"
)

const (
Expand Down Expand Up @@ -85,7 +84,6 @@ func (u *remoteUploader) Upload(localFilepath, storageFilepath string, outputTyp
start := time.Now()
location, size, err := u.upload(localFilepath, storageFilepath, outputType)
elapsed := time.Since(start)
logger.Debugw("upload complete", "fileType", fileType, "time", elapsed.String())

// success
if err == nil {
Expand Down
2 changes: 0 additions & 2 deletions pkg/pipeline/watch.go
Original file line number Diff line number Diff line change
Expand Up @@ -276,8 +276,6 @@ func (c *Controller) handleMessageElement(msg *gst.Message) error {
return err
}

logger.Debugw("fragment closed", "location", filepath, "runningTime", t)

// We need to dispatch to a queue to:
// 1. Avoid concurrent access to the SegmentsInfo structure
// 2. Ensure that playlists are uploaded in the same order they are enqueued to avoid an older playlist overwriting a newer one
Expand Down
4 changes: 2 additions & 2 deletions pkg/service/process.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,14 @@ func (p *Process) Gather() ([]*dto.MetricFamily, error) {
// Get the metrics from the handler via IPC
metricsResponse, err := p.ipcHandlerClient.GetMetrics(context.Background(), &ipc.MetricsRequest{})
if err != nil {
logger.Warnw("Error obtaining metrics from handler, skipping", err, "egress_id", p.req.EgressId)
logger.Warnw("failed to obtain metrics from handler", err, "egress_id", p.req.EgressId)
return make([]*dto.MetricFamily, 0), nil // don't return an error, just skip this handler
}
// Parse the result to match the Gatherer interface
parser := &expfmt.TextParser{}
families, err := parser.TextToMetricFamilies(strings.NewReader(metricsResponse.Metrics))
if err != nil {
logger.Warnw("Error parsing metrics from handler, skipping", err, "egress_id", p.req.EgressId)
logger.Warnw("failed to parse metrics from handler", err, "egress_id", p.req.EgressId)
return make([]*dto.MetricFamily, 0), nil // don't return an error, just skip this handler
}

Expand Down

0 comments on commit c23c430

Please sign in to comment.