Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
There was a timing window when the handler grpc client was available, but before it was ready to send back metrics and if metrics were gathered there, the whole HTTP metrics response would be something like this ``` An error has occurred while serving metrics: [from Gatherer #2] rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial unix /tmp/EGH_ME3wf4gMCrac/service_rpc.sock: connect: no such file or directory" ``` That came from prometheus.registry.go:761, which sends back an error from the `Gatherers.Gather()` invocation which the Prometheus HTTP handler then decides to return. What I've done is to quietly swallow errors from the handler (after logging) and simply return empty metrics objects and no error.
- Loading branch information