check chrome failure type

livekit · May 16, 2024 · 3b2fc78 · 3b2fc78
1 parent 8fcd028
commit 3b2fc78
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/pkg/errors/errors.go b/pkg/errors/errors.go
@@ -104,6 +104,10 @@ var (
 	ErrShuttingDown               = psrpc.NewErrorf(psrpc.Unavailable, "server is shutting down")
 )
 
+func ErrPageLoadFailed(err string) error {
+	return psrpc.NewErrorf(psrpc.InvalidArgument, "template page load failed: %s", err)
+}
+
 func ErrCouldNotParseConfig(err error) error {
 	return psrpc.NewErrorf(psrpc.InvalidArgument, "could not parse config: %v", err)
 }

diff --git a/pkg/info/info.go b/pkg/info/info.go
@@ -50,8 +50,6 @@ func (e *EgressInfo) SetFailed(err error) {
 	var perr psrpc.Error
 	if errors.As(err, &perr) {
 		e.ErrorCode = int32(perr.ToHttp())
-	} else {
-		e.ErrorCode = int32(http.StatusInternalServerError)
 	}
 }
 

diff --git a/pkg/pipeline/source/web.go b/pkg/pipeline/source/web.go
@@ -38,6 +38,8 @@ import (
 const (
 	startRecordingLog = "START_RECORDING"
 	endRecordingLog   = "END_RECORDING"
+
+	chromeFailedToStart = "chrome failed to start:"
 )
 
 type WebSource struct {
@@ -314,11 +316,15 @@ func (s *WebSource) launchChrome(ctx context.Context, p *config.PipelineConfig,
 		),
 	)
 	if err != nil {
-		return errors.ErrProcessStartFailed(err)
+		if strings.HasPrefix(err.Error(), chromeFailedToStart) {
+			return errors.ErrProcessStartFailed(err)
+		}
+		errString = err.Error()
 	}
 	if errString != "" {
-		return errors.New(errString)
+		return errors.ErrPageLoadFailed(errString)
 	}
+
 	return nil
 }