In the examples, add a helper function to generate a random user identity #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c68155e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Ocupe
changed the title
size-limit report 📦
|
|
nice, while we're at it, can we change it in a way that clicking the link in the overview menu also uses this function? so that opening the link multiple times generates a new user identity each time? |
lukasIO
approved these changes
Nov 6, 2023
I have removed the Faker dependency and only use the new random user ID function. |
|
huh, that's even better :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to improve the user experience when using the examples. It is the direct result of a user request that encountered this problem.
When running the examples and then navigating directly to
localhost:3000/minimalwith two tabs, you end up with two identical users kicking each other out of the room.To prevent this from ever happening again, we now generate a random user id if no user id is set with the
userquery parameter.