Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-published orphaned icons #647

Merged
merged 6 commits into from
Oct 16, 2023

Conversation

hehehai
Copy link
Contributor

@hehehai hehehai commented Sep 23, 2023

Duplicated with the SvgQualityUnknownIcon.tsx file?

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2023

🦋 Changeset detected

Latest commit: 0988fb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@livekit/components-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2023

CLA assistant check
All committers have signed the CLA.

@Ocupe
Copy link
Contributor

Ocupe commented Sep 27, 2023

@hehehai Thanks for bringing this to our attention 👍.
I have made some additions. All icons are generated, so I made sure we remove all of them before generating new ones. I also added a warning that the icons are generated automatically.

@Ocupe Ocupe changed the title Remove excess icon Remove non-published orphaned icons Sep 27, 2023
@Ocupe Ocupe requested a review from lukasIO September 27, 2023 11:40
@hehehai
Copy link
Contributor Author

hehehai commented Sep 27, 2023

@Ocupe thx! Cool, automatically generating resources is a good way to synchronize, and I found this problem when I copied resource files.

I'm trying to write vue components, But I see that the component library seems to be refactoring.
main...hehehai:components-js:hehehai/support-vue

@Ocupe Ocupe merged commit 8d760ea into livekit:main Oct 16, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants