-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preserve casing in generated docs page slugs #1052
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: ade62d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can understand the motivation, but I don't think the gain is worth the cost (on the docs site) of the change.
This is of course a discussion about tased, but I don't particularly like case sensitive urls and would rather change it to kebab-case if we have to change it at all.
@bcherry I see my mistake now. I meant to say that I don't like the look of urls with non-uppercase characters. But as I said, that is just my taste.
Thanks for listing some examples from other docs, I appreciate the overview! |
right now these get lowercased which makes the links less readable