Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace instanceof LocalParticipant checks #1051

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Replace instanceof LocalParticipant checks #1051

merged 1 commit into from
Dec 14, 2024

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Dec 14, 2024

follow up to #1050.

There are still additional places where we perform instanceof checks for tracks and track publications. To remove those we'll first need an update to the client sdk exposing something like participant.isLocal on tracks and publications.

@lukasIO lukasIO requested review from davidzhao and Ocupe December 14, 2024 09:08
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
LiveKitRoom only 6.05 KB (0%)
LiveKitRoom with VideoConference 29.82 KB (-0.1% 🔽)
All exports 36.51 KB (-0.16% 🔽)

davidzhao
davidzhao approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. good call on checking this

@lukasIO lukasIO merged commit 2073a8a into main Dec 14, 2024
3 checks passed
@lukasIO lukasIO deleted the lukas/more-local-checks branch December 14, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

@Ocupe Ocupe Awaiting requested review from Ocupe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasIO @davidzhao