Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use options instead of strigified options #1043

Closed

Conversation

toger5
Copy link

@toger5 toger5 commented Dec 6, 2024

This is another option to fix the issue, that stringify does not work on the large (optional) options.video.processor object.

Here we just only ever update if the options themselves change (no deep comp).
This could be fine but makes the requirement, that the user known they have to construct new options if they want to update the tracks.

Copy link

changeset-bot bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: bb2cdf6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

toger5 added a commit to element-hq/element-call that referenced this pull request Dec 6, 2024
 - still should not work without a fixing upstream LK:
livekit/components-js#1042
livekit/components-js#1043
toger5 added a commit to element-hq/element-call that referenced this pull request Dec 6, 2024
 - still should not work without a fixing upstream LK:
livekit/components-js#1042
livekit/components-js#1043
hughns pushed a commit to element-hq/element-call that referenced this pull request Dec 9, 2024
 - still should not work without a fixing upstream LK:
livekit/components-js#1042
livekit/components-js#1043
@toger5
Copy link
Author

toger5 commented Dec 13, 2024

Closed in favor of #1039

@toger5 toger5 closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants