Skip to content

Commit

Permalink
Fix Prejoin camera not visible (#229)
Browse files Browse the repository at this point in the history
* refactor prejoin, fix cam not being released

* changeset

* fix log messages

* change workflow order

* fix lint

* typo
  • Loading branch information
lukasIO authored Jan 18, 2023
1 parent 9b88fd5 commit ecf7ebd
Show file tree
Hide file tree
Showing 5 changed files with 180 additions and 168 deletions.
6 changes: 6 additions & 0 deletions .changeset/yellow-timers-deny.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@livekit/components-react': patch
'@livekit/components-styles': patch
---

Fix prejoin bugs
6 changes: 3 additions & 3 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ jobs:
npm install -g yarn
yarn install
- name: Build Packages
run: yarn build

- name: ESLint
run: yarn lint

- name: Prettier
run: yarn format

- name: Build Packages
run: yarn build

- name: Run Tests
run: yarn test
2 changes: 1 addition & 1 deletion packages/react/src/components/controls/TrackToggle.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export function useTrackToggle({ source, onChange, initialState, ...rest }: UseT
);

const pending = useObservableState(pendingObserver, false);
const enabled = useObservableState(enabledObserver, !!track?.isEnabled);
const enabled = useObservableState(enabledObserver, initialState ?? !!track?.isEnabled);

React.useEffect(() => {
onChange?.(enabled);
Expand Down
Loading

0 comments on commit ecf7ebd

Please sign in to comment.