Fix initial device selection when mounting useMediaDeviceSelect

livekit · Oct 22, 2024 · c7da2a8 · c7da2a8
1 parent 370c610
commit c7da2a8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/packages/core/src/observables/room.ts b/packages/core/src/observables/room.ts
@@ -249,7 +249,6 @@ export function createActiveDeviceObservable(room: Room, kind: MediaDeviceKind)
       log.debug('activeDeviceObservable | RoomEvent.ActiveDeviceChanged', { kind, deviceId });
       return deviceId;
     }),
-    startWith(room.getActiveDevice(kind)),
   );
 }
 

diff --git a/packages/react/src/hooks/useMediaDeviceSelect.ts b/packages/react/src/hooks/useMediaDeviceSelect.ts
@@ -63,7 +63,7 @@ export function useMediaDeviceSelect({
 
   React.useEffect(() => {
     const listener = activeDeviceObservable.subscribe((deviceId) => {
-      if (deviceId) {
+      if (deviceId && deviceId !== currentDeviceId) {
         log.info('setCurrentDeviceId', deviceId);
         setCurrentDeviceId(deviceId);
       }
-Original file line number
+Diff line change
@@ Expand Up @@
           log.debug('activeDeviceObservable | RoomEvent.ActiveDeviceChanged', { kind, deviceId });
           return deviceId;
         }),
-        startWith(room.getActiveDevice(kind)),
       );
     }
@@ Expand Down @@