Avoid logging activeDevice updates for undefined active devices (#1012)

livekit · Oct 22, 2024 · bdc52a1 · bdc52a1
1 parent a1a2430
commit bdc52a1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/.changeset/slow-rats-sneeze.md b/.changeset/slow-rats-sneeze.md
@@ -0,0 +1,5 @@
+---
+"@livekit/components-react": patch
+---
+
+Avoid logging activeDevice updates for undefined active devices
diff --git a/packages/react/src/hooks/useMediaDeviceSelect.ts b/packages/react/src/hooks/useMediaDeviceSelect.ts
@@ -53,16 +53,20 @@ export function useMediaDeviceSelect({
   );
   const devices = useObservableState(deviceObserver, [] as MediaDeviceInfo[]);
   // Active device management.
-  const [currentDeviceId, setCurrentDeviceId] = React.useState<string>('');
+  const [currentDeviceId, setCurrentDeviceId] = React.useState<string>(
+    roomContext?.getActiveDevice(kind) ?? '',
+  );
   const { className, activeDeviceObservable, setActiveMediaDevice } = React.useMemo(
     () => setupDeviceSelector(kind, room ?? roomContext, track),
     [kind, room, roomContext, track],
   );
 
   React.useEffect(() => {
     const listener = activeDeviceObservable.subscribe((deviceId) => {
-      log.info('setCurrentDeviceId', deviceId);
-      if (deviceId) setCurrentDeviceId(deviceId);
+      if (deviceId) {
+        log.info('setCurrentDeviceId', deviceId);
+        setCurrentDeviceId(deviceId);
+      }
     });
     return () => {
       listener?.unsubscribe();