Don't write empty username values to local storage (#953)

livekit · Sep 6, 2024 · 9b1a259 · 9b1a259
1 parent 8b25503
commit 9b1a259
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/dry-flowers-lay.md b/.changeset/dry-flowers-lay.md
@@ -0,0 +1,5 @@
+---
+"@livekit/components-core": patch
+---
+
+Don't write empty username values to local storage
diff --git a/packages/core/src/persistent-storage/local-storage-helpers.ts b/packages/core/src/persistent-storage/local-storage-helpers.ts
@@ -16,7 +16,10 @@ function saveToLocalStorage<T extends JsonValue>(key: string, value: T): void {
   }
 
   try {
-    localStorage.setItem(key, JSON.stringify(value));
+    if (value) {
+      const nonEmptySettings = Object.entries(value).filter(([, value]) => value !== '');
+      localStorage.setItem(key, JSON.stringify(nonEmptySettings));
+    }
   } catch (error) {
     log.error(`Error setting item to local storage: ${error}`);
   }