Prepare connection / region pinning #450
Open
+467
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hiroshihorie
commented
Jul 30, 2024
•
hiroshihorie
commented
- Test local / remote urls
- Test url updates
bcherry
approved these changes
Aug 6, 2024
lukasIO
reviewed
Aug 27, 2024
Sources/LiveKit/Core/Room.swift
Outdated
| // Connect sequence successful | ||
| log("Connect sequence completed") | ||
| while true { | ||
| let region = try await resolveBestRegion() |
There was a problem hiding this comment.
I don't think we want to await region selection on initial connection?
The other SDKs don't block here and just continue immediately in order for region manager not to have any impact on connection speed
lukasIO
reviewed
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.