Fix sdp connection address mismatch issue #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome could generate sdp with c=IN IP4 <ipv6 addr> in edge case and return error when set sdp. This is not a sdk error but correct it if the issue detected.
🦋 Changeset detectedLatest commit: 9714d8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
boks1971
approved these changes
Dec 5, 2024
| 4. Press the button to watch the demo run | ||
| 1. Start server: `pnpm dev` | ||
| 1. Open browser to local URL (typically http://localhost:5173) | ||
| 1. Press the button to watch the demo run |
There was a problem hiding this comment.
Looks like some formatter getting confused?
| ); | ||
| media.connection.ip = '0.0.0.0'; | ||
| } | ||
| } |
There was a problem hiding this comment.
Is there a need to check for the other way? It says IP6 and has a v4 address?
There was a problem hiding this comment.
I don't know if it is a real case.. maybe worth to add.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome could generate sdp with c=IN IP4 in edge case and return error when set sdp. This is not a sdk error but correct it if the issue detected.