Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document pip support #1325

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Conversation

davideberlein
Copy link
Contributor

  • Add support for detecting video element visibility in Document PiP
  • Drop opacity check as the intersection observer is not triggered if an element changes opacity and the check is flawed anyway as opacity of parents isn't considered.
  • Add toggle document pip button to examples/demo page.

Closes #1317

davideberlein and others added 4 commits November 21, 2024 16:50
Drop opacity check as the intersection observer is not triggered if an element changes opacity and the check is flawed anyway as opacity of parents isn't considered.
Copy link

changeset-bot bot commented Nov 21, 2024

🦋 Changeset detected

Latest commit: 233fbc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davidzhao davidzhao requested a review from lukasIO November 22, 2024 04:58
Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you @davideberlein !

For the demo page two small nits:
It would be nice if the pip toggle could keep track of it's current state (enabled vs disabled) and there are still some exceptions spewing in the console after popping out the window where some updates are still trying to render to the window.document directly instead of to the pip document.

- make bitrate UI aware of PiP mode
@davideberlein
Copy link
Contributor Author

davideberlein commented Nov 22, 2024

ions spewing in the console after popping out the window where some updates are still trying to render to the window.document directly instead of to the pip document

Good finding there, I missed 2 spots which I added and cleaned up the rest.

Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, excited to support this new possibility :)

@lukasIO lukasIO merged commit 86a9c9c into livekit:main Nov 22, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote participant video elements in Document PiP are wrongly detected as hidden
2 participants