-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add document pip support #1325
Add document pip support #1325
Conversation
Drop opacity check as the intersection observer is not triggered if an element changes opacity and the check is flawed anyway as opacity of parents isn't considered.
🦋 Changeset detectedLatest commit: 233fbc2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you @davideberlein !
For the demo page two small nits:
It would be nice if the pip toggle could keep track of it's current state (enabled vs disabled) and there are still some exceptions spewing in the console after popping out the window where some updates are still trying to render to the window.document directly instead of to the pip document.
- make bitrate UI aware of PiP mode
Good finding there, I missed 2 spots which I added and cleaned up the rest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, excited to support this new possibility :)
examples/demo
page.Closes #1317