Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await pending publications with timeout #1324

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Await pending publications with timeout #1324

merged 2 commits into from
Nov 28, 2024

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Nov 21, 2024

previously if there was no entry in pendingPublishPromises yet, this would have resolved immediately without actually waiting for the pending publication to be published.

Copy link

changeset-bot bot commented Nov 21, 2024

🦋 Changeset detected

Latest commit: 41f3776

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 21, 2024

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 85.94 KB (+0.05% 🔺)
dist/livekit-client.umd.js 92.06 KB (+0.05% 🔺)

@lukasIO lukasIO requested review from davidzhao and nbsp November 26, 2024 10:50
@lukasIO lukasIO merged commit cc14de4 into main Nov 28, 2024
3 checks passed
@lukasIO lukasIO deleted the lukas/await-pending branch November 28, 2024 14:22
@github-actions github-actions bot mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants