Skip to content

Commit

Permalink
Ensure permission request for listDevices works also in Firefox (#1188)
Browse files Browse the repository at this point in the history
* Ensure permission request for listDevices works also in Firefox

* Create witty-melons-clean.md
  • Loading branch information
lukasIO authored Jul 12, 2024
1 parent b8a9d48 commit f33a6ad
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/witty-melons-clean.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"livekit-client": patch
---

Ensure permission request for listDevices works for audio outputs in Firefox
2 changes: 1 addition & 1 deletion src/room/DeviceManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export default class DeviceManager {
!(isSafari() && this.hasDeviceInUse(kind))
) {
const isDummyDeviceOrEmpty =
devices.length === 0 ||
devices.filter((d) => d.kind === kind).length === 0 ||
devices.some((device) => {
const noLabel = device.label === '';
const isRelevant = kind ? device.kind === kind : true;
Expand Down

0 comments on commit f33a6ad

Please sign in to comment.