Also set audioOutput on audioElements when using webAudioMix (#1145)

* Also set audioOutput on audioElements when using webAudioMix * Create four-islands-try.md
livekit · May 21, 2024 · 8ddf6a6 · 8ddf6a6
1 parent 1e8465a
commit 8ddf6a6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/.changeset/four-islands-try.md b/.changeset/four-islands-try.md
@@ -0,0 +1,5 @@
+---
+"livekit-client": patch
+---
+
+Also set audioOutput on audioElements when using webAudioMix
diff --git a/src/room/Room.ts b/src/room/Room.ts
@@ -1086,11 +1086,12 @@ class Room extends (EventEmitter as new () => TypedEmitter<RoomEventCallbacks>)
         if (this.options.webAudioMix) {
           // @ts-expect-error setSinkId is not yet in the typescript type of AudioContext
           this.audioContext?.setSinkId(deviceId);
-        } else {
-          await Promise.all(
-            Array.from(this.remoteParticipants.values()).map((p) => p.setAudioOutput({ deviceId })),
-          );
         }
+        // also set audio output on all audio elements, even if webAudioMix is enabled in order to workaround echo cancellation not working on chrome with non-default output devices
+        // see https://issues.chromium.org/issues/40252911#comment7
+        await Promise.all(
+          Array.from(this.remoteParticipants.values()).map((p) => p.setAudioOutput({ deviceId })),
+        );
       } catch (e) {
         this.options.audioOutput.deviceId = prevDeviceId;
         throw e;