Avoid throwing unhandled error for simulcast codec tracks, (#999)

* Avoid throwing unhandled error for simulcast codec tracks, log error instead * Create smooth-keys-shop.md
livekit · Feb 2, 2024 · 5e25a3d · 5e25a3d
1 parent 9eac8f3
commit 5e25a3d
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/.changeset/smooth-keys-shop.md b/.changeset/smooth-keys-shop.md
@@ -0,0 +1,5 @@
+---
+"livekit-client": patch
+---
+
+Avoid throwing unhandled error for simulcast codec tracks
diff --git a/src/room/participant/LocalParticipant.ts b/src/room/participant/LocalParticipant.ts
@@ -946,6 +946,9 @@ export default class LocalParticipant extends Participant {
       return;
     }
     const simulcastTrack = track.addSimulcastTrack(videoCodec, encodings);
+    if (!simulcastTrack) {
+      return;
+    }
     const req = new AddTrackRequest({
       cid: simulcastTrack.mediaStreamTrack.id,
       type: Track.kindToProto(track.kind),

diff --git a/src/room/track/LocalVideoTrack.ts b/src/room/track/LocalVideoTrack.ts
@@ -254,9 +254,13 @@ export default class LocalVideoTrack extends LocalTrack {
     }
   }
 
-  addSimulcastTrack(codec: VideoCodec, encodings?: RTCRtpEncodingParameters[]): SimulcastTrackInfo {
+  addSimulcastTrack(
+    codec: VideoCodec,
+    encodings?: RTCRtpEncodingParameters[],
+  ): SimulcastTrackInfo | undefined {
     if (this.simulcastCodecs.has(codec)) {
-      throw new Error(`${codec} already added`);
+      this.log.error(`${codec} already added, skipping adding simulcast codec`, this.logContext);
+      return;
     }
     const simulcastCodecInfo: SimulcastTrackInfo = {
       codec,