fix: prevent monitoring leak when stopOnUnpublish is false

livekit · Dec 7, 2024 · 4ef1076 · 4ef1076
1 parent 8b63132
commit 4ef1076
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/room/Room.ts b/src/room/Room.ts
@@ -1347,6 +1347,8 @@ class Room extends (EventEmitter as new () => TypedEmitter<RoomEventCallbacks>)
         if (shouldStopTracks) {
           pub.track?.detach();
           pub.track?.stop();
+        } else {
+          pub.track?.stopMonitor();
         }
       });
 

diff --git a/src/room/participant/LocalParticipant.ts b/src/room/participant/LocalParticipant.ts
@@ -1266,6 +1266,8 @@ export default class LocalParticipant extends Participant {
     }
     if (stopOnUnpublish) {
       track.stop();
+    } else {
+      track.stopMonitor();
     }
 
     let negotiationNeeded = false;