fix: prevent monitoring leak when stopOnUnpublish is false (#1348)

* fix: prevent monitoring leak when stopOnUnpublish is false * changeset
livekit · Dec 7, 2024 · 1b0591b · 1b0591b
1 parent 8b63132
commit 1b0591b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/.changeset/fair-laws-yell.md b/.changeset/fair-laws-yell.md
@@ -0,0 +1,5 @@
+---
+'livekit-client': patch
+---
+
+fix: prevent monitoring leak when stopOnUnpublish is false
diff --git a/src/room/Room.ts b/src/room/Room.ts
@@ -1347,6 +1347,8 @@ class Room extends (EventEmitter as new () => TypedEmitter<RoomEventCallbacks>)
         if (shouldStopTracks) {
           pub.track?.detach();
           pub.track?.stop();
+        } else {
+          pub.track?.stopMonitor();
         }
       });
 

diff --git a/src/room/participant/LocalParticipant.ts b/src/room/participant/LocalParticipant.ts
@@ -1266,6 +1266,8 @@ export default class LocalParticipant extends Participant {
     }
     if (stopOnUnpublish) {
       track.stop();
+    } else {
+      track.stopMonitor();
     }
 
     let negotiationNeeded = false;