fix: improve reconnect logic. #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcherry
approved these changes
Dec 10, 2024
|
The issue is mainly in this line https://github.com/livekit/client-sdk-flutter/pull/654/files#diff-4f309ad728e5eb8ca71a10a7283647e36936b53dc0feeb8d18edf03d3eb0d920L817. When the webrtc pc connection fails completely, fullReconnect will be triggered, but here it should clean up the signaling connection and restart to republish loca tracks. However, sending a leave request will cause the client to disconnect and be unable to restore the connection. |
cloudwebrtc
commented
Dec 10, 2024
| @@ -116,8 +118,6 @@ class SignalClient extends Disposable with EventsEmittable<SignalEvent> { | |||
|
|
|||
| if (_connectivityResult.contains(ConnectivityResult.none)) { | |||
| logger.warning('no internet connection'); | |||
| events.emit(SignalDisconnectedEvent( | |||
There was a problem hiding this comment.
There is no need to emit a SignalDisconnectedEvent event here, because connect or resumeConnect/restartConnect will catch the ConnectException and take the correct follow-up action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.