Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handling of incompatible published codecs #391

Merged
merged 4 commits into from
Nov 1, 2023
Merged

handling of incompatible published codecs #391

merged 4 commits into from
Nov 1, 2023

Conversation

cloudwebrtc
Copy link
Contributor

@cloudwebrtc cloudwebrtc marked this pull request as ready for review October 30, 2023 05:02
davidzhao
davidzhao reviewed Nov 1, 2023
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of things

lib/src/participant/local.dart Show resolved Hide resolved
lib/src/utils.dart Show resolved Hide resolved
davidzhao
davidzhao approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@cloudwebrtc cloudwebrtc merged commit 4192756 into main Nov 1, 2023
7 checks passed
@cloudwebrtc cloudwebrtc deleted the feat/handling-of-incompatible-published-codecs branch November 1, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cloudwebrtc @davidzhao