Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build.gradle for gradle 8.0.0 namespace #382

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Update build.gradle for gradle 8.0.0 namespace #382

merged 2 commits into from
Oct 17, 2023

Conversation

mostcute
Copy link
Contributor

@mostcute mostcute commented Oct 9, 2023

after agp-8.0.0 ,module need to add namespace in build.gradle

https://developer.android.com/build/releases/past-releases/agp-8-0-0-release-notes

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

cloudwebrtc
cloudwebrtc approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cloudwebrtc cloudwebrtc merged commit 401cb2e into livekit:main Oct 17, 2023
7 checks passed
@cloudwebrtc cloudwebrtc mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudwebrtc cloudwebrtc cloudwebrtc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mostcute @CLAassistant @cloudwebrtc